Remove mimalloc workaround #4606
Merged
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Jun 2, 2024
BlackDex
requested changes
Jun 6, 2024
There was a problem hiding this comment.
This unfortunately is not true.
The new mimalloc-sys crate actually breaks everything.
It also seems it has been broken for a longer time already.
So, this is something we need to look into.
The binaries do work within an Alpine environment, but not as a true static binary anymore.
|
Are we waiting for a new crate release or should I override it with commit purpleprotocol/mimalloc_rust@992c9da? |
|
I have not yet checked if the removal works for all arch's. |
dfunkt
force-pushed
the
remove-mimalloc-workaround
branch
from
70d0223
to
f40f3ba
Compare
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Jun 17, 2024
- Updated all crates including Diesel and the new mysqlclient-sys - Updated the MSRV to v1.78 as that is what Diesel mandates - Added the mimalloc crate as a patch for now to fix armv6 static builds This probably makes dani-garcia#4606 possible
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Jun 17, 2024
- Updated all crates including Diesel and the new mysqlclient-sys - Updated the MSRV to v1.78 as that is what Diesel mandates - Added the mimalloc crate as a patch for now to fix armv6 static builds This probably makes dani-garcia#4606 possible
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Jun 19, 2024
- Updated all crates including Diesel and the new mysqlclient-sys - Updated the MSRV to v1.78 as that is what Diesel mandates - Added the mimalloc crate as a patch for now to fix armv6 static builds This probably makes dani-garcia#4606 possible - Updated web-vault to v2024.5.1 - Updated GitHub Actions Fixed an issue with the localhost images for extracting the musl binaries.
dani-garcia
pushed a commit
that referenced
this pull request
Jun 19, 2024
- Updated all crates including Diesel and the new mysqlclient-sys - Updated the MSRV to v1.78 as that is what Diesel mandates - Added the mimalloc crate as a patch for now to fix armv6 static builds This probably makes #4606 possible - Updated web-vault to v2024.5.1 - Updated GitHub Actions Fixed an issue with the localhost images for extracting the musl binaries.
dfunkt
force-pushed
the
remove-mimalloc-workaround
branch
from
f40f3ba
to
d73c993
Compare
- libatomic linking for armv6 has been fixed in purpleprotocol/mimalloc_rust@992c9da
dfunkt
force-pushed
the
remove-mimalloc-workaround
branch
from
d73c993
to
9e880cc
Compare
BlackDex
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: purpleprotocol/mimalloc_rust@446fc23