-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add group support for Cipher::get_collections() #4592
base: main
Are you sure you want to change the base?
add group support for Cipher::get_collections() #4592
Conversation
omg, those queries aren't getting any prettier haha. |
I've tested it a bit with some edge cases and I don't think this currently works correctly. |
I actually think we should redesign the whole group database storage. Currently we use the exact same logic to store it as Bitwarden. But Bitwarden has some programmable logic which we do not. Not sure actually how they solved this with there SQLite implementation. |
2bcdc60
to
e6ef5ea
Compare
To fix the issues I've encountered I had to add even more queries. 😅 |
As far as I've tested it, this should now work as intended but I've not tested every possible combination of access rights and collection assignments so I might have missed something (hopefully not something obvious 😳 ). |
e78b002
to
46273af
Compare
@stefan0xC Question for you. |
@jb2barrels Not sure if this is related. Is this a visual bug (where it only seems possible but it actually isn't) or can entries actually be changed without write access to a collection? |
The extension will show the change was made to the password entries' collections. I'm wondering if it has anything to do with the client receiving a response (or empty response) thinking its successful, when the user did not have permission. |
I'm not sure I can replicate your issue. Even without my changes I get an error ( |
a395361
to
6ff5f41
Compare
join group infos assigned to a collection to check whether user has been given access to all collections via any group or they have access to a specific collection via any group membership
prevent side effects if groups are disabled
6ff5f41
to
9af6f86
Compare
join group infos assigned to a collection to check whether user has been given access to all collections via any group or they have access to a specific collection via any group membership
fixes #4588