Requests page #7537
Requests page #7537
Conversation
…nto kl/data-processing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| field_name=StorageType.TARGET, | ||
| ) | ||
| except ValueError as ex: | ||
| raise serializers.ValidationError(str(ex)) from ex |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
… deferred job registry
Marishka17
force-pushed
the
kl/data-processing
branch
from
ffbf718
to
4493302
Compare
| - basicAuth: [] | ||
| responses: | ||
| '202': | ||
| description: Exporting has been started |
There was a problem hiding this comment.
This returns a request ID, right? Can you add a response schema?
| created_date: | ||
| type: string | ||
| format: date-time | ||
| readOnly: true | ||
| enqueued_date: | ||
| type: string | ||
| format: date-time | ||
| readOnly: true | ||
| nullable: true |
There was a problem hiding this comment.
Is there a meaningful difference between created_date and enqueued_date, as far as the user is concerned? If a request was created, it must have also been enqueued.
There was a problem hiding this comment.
Probably not for now, but I think it depends on whether we're going to inform the user about deferred jobs or continue to mask them as queued.
There was a problem hiding this comment.
Then let's only expose one of these fields until such a time when there's a reason to expose the other one.
(FWIW, my vote is for created_date, as that would be consistent with other API resources.)
Marishka17
force-pushed
the
kl/data-processing
branch
from
4493302
to
aa9ec46
Compare
|
|
I will close this PR and re-open it. It became messy with lots of comments from AI tools and reviews. |
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
cy.goBack()after export operations.Refactor
importingandbackupIsActiveacross multiple components.Tests
Documentation
Chores