-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] build: enable WinIDN by default #13947
Conversation
Tests are unprepared to handle IDN with Windows, both UNICODE and non-UNICODE modes (but differently). |
Unexpected fallout with VS2008. Vista target, Normaliz.lib specified, yet the IDN functions are not found:
Anybody with a solution for the above issue?
|
The VS2008 issue was reported here earlier: #1863 This trace message says that
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50021801/job/xpd1d5cor294gp3m#L42 It feels like something very obvious (or something very cryptic). Seeing the actual linker command would tell more of what's happening. |
Windows XP is not compatible with WinIDN by default. It requires a `normaliz.dll` to be installed, but the necessary package is no longer offered by Microsoft. Thus, for Windows XP compatibility, we recommend building with `-DUSE_WIN32_IDN=OFF`. Discussion: curl#13565 Closes #xxxxx
Backing off of this. It looks nearly hopeless to make IDN tests pass on Windows (without going crazies that is.) It needs passing Unicode text via the command-line for starters. Also the unexplained VC2008 fallout. Then autotools. I might cherry pick the part moving WINVER detection up to the top. Feel free to pick up and continue. |
Windows XP is not compatible with WinIDN by default. It requires
a
Normaliz.dll
to be installed, but the necessary package is no longeroffered by Microsoft. Thus, for Windows XP compatibility, we recommend
building with
-DUSE_WIN32_IDN=OFF
.Discussion: #13565
Closes #13947
Cleaner diff without whitespace changes: https://github.com/curl/curl/pull/13947/files?w=1
There are a few ways to resolve compatibility with existing builds
and also to handle interactions with the
USE_LIBIDN2
option.This is an initial attempt.
TODO:
HAVE_WIN32_WINNT
and adjust defaultUSE_WIN32_IDN
setting accordingly?