WIP - Baseline #1447
Closed
WIP - Baseline #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is working. Next up: - isolate the test_server failing tests - move the settings mock into a conftest fixture - add a test hook for SyncServer so you can do the same thing there. - propigate.
for default persona, human, and preset. Now all derived from settings (which is in turn derived from envars). Still need to square away with the config file hierarchy, so once we resolve the value there is only one definitive source of truth across the rest of the code.
|
Migrated to config parser work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stubbed settings locally in test_server ✅
next up
Please describe the purpose of this pull request.
this is to get a baseline of isolated tests that are passing before making substantial changes.
How to test
when this is good, all the tests will run and pass without any special environment setup.
Have you tested this PR?
This is a PR for the test env
Related issues or PRs
N/A
Is your PR over 500 lines of code?
This will be a very large PR. Ideally it is removing more than 500 lines of code 💥
Additional context
Before we can dig into adding model structure I'd like as much of a smoke test setup as we can have in place.