chore: light status icon default text color #7828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status icon is currently picking up the default text (fill) color from the parent. This is fine at the moment while the default is white, but once we set the default text color in light mode to black (see PR containers#7729) the fill color would change to black. This provides a new status color to use for the icons so that (as per design) they use their own color and do not pick up the default/parent text color. I wasn't 100% sure it should be a '--pd-status' color since this isn't a status color per se like running or stopped, but it's much more obvious that it is related to the other status colors. Related to containers#7729. Fixes containers#7728. Signed-off-by: Tim deBoer <[email protected]>
deboer-tim
requested review from
dgolovin and
jeffmaury
and removed request for
a team
benoitf
reviewed
Jun 27, 2024
Comment on lines
+1185
to
+1191
|
|
||
| // contrast color for the other status colors, | ||
| // e.g. to use in status icons | ||
| this.registerColor(`${status}contrast`, { | ||
| dark: colorPalette.white, | ||
| light: colorPalette.white, | ||
| }); |
There was a problem hiding this comment.
not sure why to define a color if it's always white ?
There was a problem hiding this comment.
Because it was still a design choice. If someone else was making a theme they might be ok with less contrast (maybe an off white), something else might work better with their status colors, or could go transparent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The status icon is currently picking up the default text (fill) color from the parent. This is fine at the moment while the default is white, but once we set the default text color in light mode to black (see PR #7729) the fill color would change to black.
This provides a new status color to use for the icons so that (as per design) they use their own color and do not pick up the default/parent text color.
I wasn't 100% sure it should be a '--pd-status' color since this isn't a status color per se like running or stopped, but it's much more obvious that it is related to the other status colors.
Screenshot / video of UI
No visual change.
What issues does this PR fix or reference?
Related to #7729. Fixes #7728.
How to test this PR?
Automated tests, check status icon in a few different states.