-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Task): removing gotoTask field #7799
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: axel7083 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 to the cleanup, but why rename? Especially if you're deprecating I don't know why to bother.
I also don't understand what would come next after the deprecation, as this isn't linked to a specific issue/clear what the replacement would be.
Based on before and after images, my understanding is that you've made this 10s faster. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming something that you are deprecating seems opposite
packages/renderer/src/lib/preferences/preferences-connection-rendering-task.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: axel7083 <[email protected]>
Signed-off-by: axel7083 <[email protected]>
The idea was the task can have an action, but not on the renderer side |
Code LGTM but deprecation should come once there is an alternative |
What does this PR do?
In the
StatefulTask
interface we hadgotoTask
andaction
, the first one was just a kinda simplification of the second. This PR remove thegotoTask
, renameaction
torendererAction
and deprecate it.Screenshot / video of UI
before
![image](https://private-user-images.githubusercontent.com/42176370/342329758-28741d94-2c02-44e4-9d34-87e5757643e4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NTM4NjYsIm5iZiI6MTcxOTY1MzU2NiwicGF0aCI6Ii80MjE3NjM3MC8zNDIzMjk3NTgtMjg3NDFkOTQtMmMwMi00NGU0LTlkMzQtODdlNTc1NzY0M2U0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA5MzI0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5YzcxMWE2ZjgzMzQ4Zjg4NDE2ZWZjNTY0YzFhODNlMjY0N2RjNjBmOGE5NDY0OGE4YTgzMmQyMjhiMWNkOWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.I34__xtRh1MeJbBuU2pI9TULkY-VTBQLf3P2VKfqBMM)
After
What issues does this PR fix or reference?
Related to #7401
How to test this PR?