-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable light mode for buildImageFromContainerfile page #7773
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: lstocchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and worked well in testing. My only concern is if we should really have --pd-formpage-card*, i.e. whether these should be generic cards (variable names without formpage) or there are existing color variables we should use. @ekidneyrh any preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Same remarks about reusing variables
Not sure how to change the variables name. By looking at other cases i see that the cards used for carousel have |
Our design has most items that always look the same no matter where they are (Buttons, Inputs, Checkboxes, etc), and then some things like content cards that are different depending on context like Dashboard vs Settings. If the design/colors for the platform cards don't match tiles like on the dashboard or elsewhere then I'm fine if they are new vars just for forms, but card-input-bg is definitely 'wrong' because inputs shouldn't change based on where they are. Can you pick up some of the input-field colors instead or switch to use Input instead of defining a new color? |
What does this PR do?
This PR enables light mode in the build image from container file page.
It is built over #7768
Screenshot / video of UI
What issues does this PR fix or reference?
it is part of #7214
How to test this PR?
go to images -> click on build button (top right)