fix: click on the dock icon should display dashboard

[benoitf]

What does this PR do?

if we were clicking on the icon with dashboard being closed, it was not bringing back the dashboard

track the event and add it back.

I don't know if there is such a case on Windows being possible so I added a isMac test

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #7403

How to test this PR?

• Tests are covering the bug fix or the new feature

[feloy]

I'm able to test on Mac with yarn watch only.

Here are the steps I'm doing:

• start the app with yarn watch
• close the window
• in the app icon, Options -> Keep in Dock
• close the window
• click the app icon
• the window appears as expected
• but, the dot below the icon (indicating a window is visible) is not displayed, and the context menu of the icon is not updated accordingly

[benoitf]

I'm able to test on Mac with yarn watch only.

hmm why you can only use the yarn watch mode only ?

but, the dot below the icon (indicating a window is visible) is not displayed, and the context menu of the icon is not updated accordingly

AFAIK it might be another issue, it's not related to this change

[feloy]

I'm able to test on Mac with yarn watch only.

hmm why you can only use the yarn watch mode only ?

When I build the app with yarn compile, I get the error Code Signature Invalid when trying to execute it, I suppose because I don't have the keys to sign the app for MacOS.

[feloy]

but, the dot below the icon (indicating a window is visible) is not displayed, and the context menu of the icon is not updated accordingly

AFAIK it might be another issue, it's not related to this change

OK, apart from this problem, it works as expected. LGTM

[deboer-tim]

Two concerns from testing:

• I'm using yarn watch mode, but this was only working the first time for me - i.e. I close the window and can reopen it, but then if I close again, clicking on the icon does nothing. No error is reported, so I guess it still thinks the window is open?

• With this change, using the toolbar context menu is less intuitive/standard. I can still get to it using a right (two finger) click, but I looked at how other apps on the Mac behave, and aside from one that doesn't have a context menu at all (Sentinel), clicking on all others (Google desktop, Logitech, Stream Deck) only opens the context menu as we do today.

[benoitf]

With this change, using the toolbar context menu is less intuitive/standard. I can still get to it using a right (two finger) click, but I looked at how other apps on the Mac behave, and aside from one that doesn't have a context menu at all (Sentinel), clicking on all others (Google desktop, Logitech, Stream Deck) only opens the context menu as we do today.

@deboer-tim could you explain what is your 'toolbar context menu' (screenshot or screencast) to be sure we're talking about the same thing ?

[deboer-tim]

With this change, using the toolbar context menu is less intuitive/standard. I can still get to it using a right (two finger) click, but I looked at how other apps on the Mac behave, and aside from one that doesn't have a context menu at all (Sentinel), clicking on all others (Google desktop, Logitech, Stream Deck) only opens the context menu as we do today.

@deboer-tim could you explain what is your 'toolbar context menu' (screenshot or screencast) to be sure we're talking about the same thing ?

Not sure what I've done to my machine or if it is the connection I'm on but I can't get this PR to work at all now, will try again later. However, I meant the Mac toolbar / system menu / system tray. After this change it was less obvious how to get to the context menu showing machines and Kubernetes context switcher.