Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inform user when default connection is not in line with machine native option #7627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Jun 13, 2024

What does this PR do?

This PR adds a check from the desktop side to see if someone is running a machine using the wrong connection. Like the running machine is rootful but the default connection is rootless.

There is a known bug on podman containers/podman#22993 that it happens when you delete a machine but it also may happen if the user mess up using the cli.
This way we prompt a message to inform the user that they should update the connection

Screenshot / video of UI

update_connection

What issues does this PR fix or reference?

It resolves #7052 and maybe #6455

How to test this PR?

  1. Create a rootful machine and start it
  2. Create another rootful/rootless (it's the same) machine and start it
  3. At this point, on Podman Desktop, you will be asked if you want to update the default connection -> yes
  4. Stop the latest rootful/rootless machine -> on Podman Desktop you will be asked if you want to update the default connection -> yes -> the rootful connection of the first machine is set to default
  5. delete the latest rootful/rootless machine.
  6. if you check again you will see the default connection of the first machine has been updated to the rootless one
  7. a message is prompted to update the connection
  • Tests are covering the bug fix or the new feature

@lstocchi lstocchi requested review from benoitf and a team as code owners June 13, 2024 11:05
@lstocchi lstocchi requested review from jeffmaury and axel7083 and removed request for a team June 13, 2024 11:05
@lstocchi lstocchi requested a review from jeffmaury June 19, 2024 07:05
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi
Copy link
Contributor Author

Rebasing as i saw one gh workflow didn't trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootful podman machine gets stuck using rootless connection after another rootless machine is deleted
2 participants