Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode for individual forms #7214

Open
Tracked by #4914
deboer-tim opened this issue May 14, 2024 · 0 comments · Fixed by #7538 · May be fixed by #7774
Open
Tracked by #4914

Light mode for individual forms #7214

deboer-tim opened this issue May 14, 2024 · 0 comments · Fixed by #7538 · May be fixed by #7774
Assignees
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

Issue #6889 / PR #7149 added support to light mode for nav page and form page, but the individual form pages all have hard-coded colors (e.g. most forms have a rounded div with bg-charcoal-600).

Describe the solution you'd like

Extract any missing current colors to the registry and add light mode colors.

Priority to doing a first pass of all forms for obvious colors like the bg-charcoal-600 above, and seeing if we can now move this 'up' into FormPage. Second pass for any other obvious/common colors, then assess if there are unique forms that need more work.

Describe alternatives you've considered

No response

Additional context

No response

@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label May 14, 2024
@deboer-tim deboer-tim mentioned this issue May 14, 2024
46 tasks
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
We should not hardcode a default text colour to white, especially in light
mode. This is the (temporary) cause of many issues like containers#7708 where we
hadn't yet set a light mode color so you get white on light.

We don't have a 'default text color' and none of the existing palette
entries fit, so I talked to Emma and decided to create a new variable.

Unfortunately, even though this is a 'correct' change, setting it right
now has the reverse problem: anything that is still missing light mode
support will see the default text color change from white to dark and
have problems on dark backgrounds. A quick test showed the following:

- some forms (containers#7214)
- containers#7727
- containers#7728

So we should not move this out of draft until most of these are fixed,
and definitely not immediately before a release. In the meantime, it's
handy to set this to something really obvious (e.g. amber) to see what
still needs light mode support.

Fixes containers#7724.

Signed-off-by: Tim deBoer <[email protected]>
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 19, 2024
Initial light mode support for container and Kubernetes details screens.

Just removed two hardcoded dark mode colors: charcoal header and zinc
summary page. Set the same text color as other Summary pages to make the
text visible.

For editing there is no great place to set the text color until containers#7214
and containers#7547 are in, so for now the text color is set 'manually' using a
div.

Fixes containers#7731.

Signed-off-by: Tim deBoer <[email protected]>
@lstocchi lstocchi reopened this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 🚥 In Review
4 participants