-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward retryablehttp logs to tflog #374
base: master
Are you sure you want to change the base?
Forward retryablehttp logs to tflog #374
Conversation
Fabio Silva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
Fabio Silva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@FabioBatSilva thanks for creating the PR! What would be the best way to test these changes locally? One option I see is checking whether HTTP call logs are no longer double-formatted:
(for example, like the 2nd and the 3rd lines here)
|
Hi, When you run terraform with
|
This PR is Introducing a adapter that sends retryablehttp logs to tflogs.
Current retryablehttp logs get double formatted by it's logger
Inspired by https://github.com/hashicorp/terraform-provider-http/blob/2982166a23c297b6e934c74539cc5e66c5eca056/internal/provider/data_source_http.go#L413-L444
See:
pulumi/pulumi-confluentcloud#48.
#372