DGS-10707 Cache checkpoint for cacheInitialized before reader thread starts #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhileshm1
previously approved these changes
Jun 26, 2024
rayokota
reviewed
Jun 26, 2024
core/src/main/java/io/confluent/kafka/schemaregistry/storage/KafkaStore.java
Outdated
Show resolved
Hide resolved
| @@ -153,7 +157,7 @@ public void init() throws StoreInitializationException { | |||
| throw new StoreInitializationException("Illegal state while initializing store. Store " | |||
| + "was already initialized"); | |||
| } | |||
| this.storeUpdateHandler.cacheInitialized(new HashMap<>(kafkaTopicReader.checkpoints())); | |||
| this.storeUpdateHandler.cacheInitialized(new HashMap<>(checkpoints)); | |||
There was a problem hiding this comment.
Suggested change
| this.storeUpdateHandler.cacheInitialized(new HashMap<>(checkpoints)); | |
| this.storeUpdateHandler.cacheInitialized(checkpoints); |
rayokota
requested changes
Jun 26, 2024
|
Also we should target 7.0.x with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cache checkpoint for cacheInitialized before reader thread starts. Checkpoint could be updated once the reader thread starts. This could result in a race condition where schemas after the checkpoint during startup would be double counted.
References
https://confluentinc.atlassian.net/browse/DGS-10707