Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont log query text when materialize off #9675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: dont log query text when materialize off #9675

wants to merge 1 commit into from

Conversation

rodesai
Copy link
Contributor

@rodesai rodesai commented Oct 28, 2022

dont log query text when materialization is off, just log the id

@rodesai rodesai requested a review from a team as a code owner October 28, 2022 21:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vcrfxia
Copy link
Contributor

vcrfxia commented Oct 31, 2022

Looks like this is meant to address the same thing as this other PR -- I have the same question here too: #9677 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvcephei vvcephei vvcephei approved these changes

@jnh5y jnh5y jnh5y approved these changes

@ap00rv ap00rv ap00rv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rodesai @CLAassistant @vcrfxia @vvcephei @jnh5y @ap00rv