AKCORE-137: Prepare consumer for merge #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
requested review from
apoorvmittal10 and
ShivsundarR
and removed request for
a team
ShivsundarR
approved these changes
Jun 26, 2024
| @@ -1244,8 +1245,10 @@ public void testAcknowledgeCommitCallbackThrowsException() { | |||
|
|
|||
| shareConsumer.poll(Duration.ofMillis(2000)); | |||
|
|
|||
| // The second poll sends the acknowledgments implicitly. Once the response for the acknowledgements is | |||
| // received, the acknowledgement commit callback will be called and the exception is thrown. | |||
| // The second poll sends the acknowledgments implicitly. Once the response for the acknowledgements is received. | |||
There was a problem hiding this comment.
nit : the second line can be removed in the comment.
apoorvmittal10
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the share group consumer using the latest code in AK in preparation for an AK PR.
Committer Checklist (excluded from commit message)