AKCORE-167-2: Minor bugfix, shareStateMap was being updated twice for a single WriteShareGroupState operation #1293
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a single wrteShareGroupState operation
AndrewJSchofield
requested changes
Jun 13, 2024
| @@ -251,20 +251,18 @@ public CoordinatorResult<WriteShareGroupStateResponseData, Record> writeState(Re | |||
| WriteShareGroupStateResponseData responseData = new WriteShareGroupStateResponseData(); | |||
| for (Record record : recordList) { // should be single record | |||
| if (record.key().message() instanceof ShareSnapshotKey && record.value().message() instanceof ShareSnapshotValue) { | |||
| ShareSnapshotKey newKey = (ShareSnapshotKey) record.key().message(); | |||
| ShareSnapshotValue newValue = (ShareSnapshotValue) record.value().message(); | |||
| ShareSnapshotKey recordKeyKey = (ShareSnapshotKey) record.key().message(); | |||
There was a problem hiding this comment.
recordKeyKey??? I know it's trivial but please can we have a less comical name :)
There was a problem hiding this comment.
Thanks for the review, sorry about this 😅 The changes are there in the latest commit
AndrewJSchofield
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the
CoordinatorRuntimecode, the replay method is called eventually, which should be responsible for the updations to the TimelineHashMaps (shareStateMapin our case). The replay function correctly updates theshareStateMapwith the generated records, but an additional update to theshareStateMapwas being made in thewriteStatefunction to update the snapshot epoch, causing double updates for a singleWriteShareGroupStateoperation. This PR removes this additional update in thewriteStatefunction and generates the corrected records with the correct snapshot epoch value, which will be put in theshareStateMapduring replay