Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Migrate to reanimated 2 #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ngocle2497
Copy link

This PR uses Reanimated 2 to be supported by JSI instead of Bridge

@CharlesMangwa
Copy link
Member

Hey @MasonLe2497! Thank you for this great PR! I've been thinking about switching Modalfy to Reanimated v2 for a long time, just was waiting to ship some other features & fixes before that. I'll go over your PR and try to get it merge as soon as I'll have a minute! 💪

@ngocle2497
Copy link
Author

I tested on android device, and it works with 60fps
https://user-images.githubusercontent.com/43195241/157888496-336df1f1-d2c0-4dad-aeb4-2abeb29b9c4d.mov

@ngocle2497
Copy link
Author

But with this PR, transitionOptions must be a 'worklet' function return ViewStyle

@CharlesMangwa
Copy link
Member

Yeah, I suspected that the switch to Reanimated 2 would be a breaking change and would require a major app update, shouldn't be much of an issue if the doc has proper migration guide.

@CharlesMangwa CharlesMangwa self-assigned this Mar 11, 2022
@CharlesMangwa CharlesMangwa added the new feature New feature or request label Mar 11, 2022
@LeviWilliams
Copy link

Hey! I'm looking into migrating to this library and v2 reanimated support is something on our list, is there any chance this is on the docket still? Love the lib design so far too nice work

@LeviWilliams
Copy link

@MasonLe2497 Thinking about patching this into my project, have you used in production at all? Thanks!

@tonihm96
Copy link

hey! is this still being worked on? I'd love to see modalfy having support for reanimated 😄

@CharlesMangwa
Copy link
Member

hi @tonihm96. no this is currently not being worked on. we'll try to keep you posted once this gets on top of our todo list 👍

@GaeCuure
Copy link

would love to see modalfy having support for reanimated !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants