aws - rds-param-group - add db-parameter filter #9570
+637
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thisisshi submitted a new PR based on discussion in #9505 |
|
@kapilt @ajkerrigan @thisisshi could i have a review for this PR |
ajkerrigan
approved these changes
Jun 25, 2024
kapilt
reviewed
Jun 25, 2024
|
|
||
| @staticmethod | ||
| def recast(val, datatype): | ||
| """ Re-cast the value based upon an AWS supplied datatype |
There was a problem hiding this comment.
I would prefer not to see this duplicated between rds and rds cluster modules, ie. its a static method in the original so you can omit this and just import rds module and use the ParameterFilter.recast method at call sites instead of copy/pasting here.
kapilt
reviewed
Jun 25, 2024
| self.assertEqual(len(resources), 1) | ||
|
|
||
|
|
||
| class ParameterFilterTestCase(BaseTest): |
There was a problem hiding this comment.
these test cases also go away without the duplicate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rds and rdscluster resource currently does not support an action to modify the parameter group attached to a db instance or cluster. Our compliance operations require a policy that checks if a db instance or cluster parameter group has TLS encryption enabled and set to correct version. we would need a filter for db - parameters.
Sample policy