-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws - ssm - session-manager-regional-settings support #9534
base: main
Are you sure you want to change the base?
aws - ssm - session-manager-regional-settings support #9534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's actually do a value filter here maybe of type: content
so that we can do arbitrary filters on the values inside the document:
policies:
- name: ssm-doc-content-filter
resource: aws.ssm-document
filters:
- type: content
key: foo
value: bar
client = local_session(self.manager.session_factory).client('ssm') | ||
|
||
def _augment(r): | ||
# List tags for the Notebook-Instance & set as attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as noted in the community call, this should really be more of a separate content filter on documents, rather then augment to avoid extra api calls for use cases where the content is not the focus, ie tag policies for example.
Closes #9386, #9535