-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerkjs): Set localhost SameSite=None cookies as Secure #3604
base: main
Are you sure you want to change the base?
fix(clerkjs): Set localhost SameSite=None cookies as Secure #3604
Conversation
🦋 Changeset detectedLatest commit: 1f5b5e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ic-fix-from-clerkjs
!snapshot |
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i [email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
So it seems this PR reverts #3245 and proposes another solution |
@panteliselef Exactly! This PR removes the hacky Cypress fix and proposes a more holistic solution for |
Description
This PR removes the specific fix we did a while ago for Cypress.
The real reason our cookies where getting deleted in Cypress Chrome is because Chrome requires
Secure
when settingSameSite=None
cookies.Safari needs a bit of a different handling because it does not consider
localhost
to be a secure context, so in Safari localhost cookies cannot have theSecure
attribute.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change