Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: AWS route53: Set global region for sts #7108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BUGFIX: AWS route53: Set global region for sts #7108

wants to merge 3 commits into from
+13 −5

Conversation

inteon
Copy link
Member

@inteon inteon commented Jun 18, 2024 •
edited
Loading

fixes #7102

I think this issue was introduced in #6671, the v2 version of the aws sdk does now require a region to be provided for the sts client. We now have to explicitly provide the "aws-global" value to be used by the sts client (see go-acme/lego#2067 (comment)).

@pchang388 could you verify this solves your issue?

Kind

/kind bug

Release Note

BUGFIX route53: explicitly set the "aws-global" sts region which is now required by the github.com/aws/aws-sdk-go-v2 library.

@cert-manager-prow cert-manager-prow bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 18, 2024
@inteon
Copy link
Member Author

inteon commented Jun 18, 2024

/retest

@inteon inteon force-pushed the bugfix_aws branch 2 times, most recently from 0ba2b47 to df7689f Compare June 18, 2024 16:30
@inteon inteon changed the title Set region before calling sts AWS route53: Set global region for sts Jun 19, 2024
@inteon inteon requested a review from wallrj June 19, 2024 13:09
wallrj
wallrj requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I've left some remarks and requests for more explanatory comments.

pkg/issuer/acme/dns/route53/route53.go Show resolved Hide resolved
pkg/issuer/acme/dns/route53/route53.go Outdated Show resolved Hide resolved
wallrj
wallrj approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim,

I haven't tested this because I don't have access to an AWS account.

/lgtm
/hold until @pchang388 confirms that this solves the problem he reported

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 19, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@inteon inteon changed the title AWS route53: Set global region for sts BUGFIX: AWS route53: Set global region for sts Jun 24, 2024
@k11h-de k11h-de mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route53 Provider Assume Role Error - Missing Region
2 participants
@inteon @wallrj