Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to split a cert-manager installation over multiple Helm releases. #7061

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FR-Solution
Copy link

@FR-Solution FR-Solution commented May 31, 2024

Good day

This feature is required for fine-tuning the environment in our clusters, specifically, we want to be able to disable all resources within the scope of a release.

custom-values.yaml

# Disabled all by default
global:
  podSecurityPolicy:
    enabled: false
    useAppArmor: false
  rbac:
    create: false
 
certManager:
  enabled: false

serviceAccount:
  create: false
  automountServiceAccountToken: false

securityContext:
  runAsNonRoot: false

prometheus:
  enabled: false
  servicemonitor:
    enabled: false
    honorLabels: false

webhook:
  enabled: false
  securityContext:
    runAsNonRoot: false
  serviceAccount:
    create: false
    automountServiceAccountToken: false
  hostNetwork: false

cainjector:
  enabled: false

  securityContext:
    runAsNonRoot: false

  serviceAccount:
    create: false
    automountServiceAccountToken: false

startupapicheck:
  enabled: false

  securityContext:
    runAsNonRoot: false

  serviceAccount:
    create: false
    automountServiceAccountToken: false

installCRDs: false

helm template . -f custom-values.yaml

In our company, there are requirements for charts to meet certain criteria, such as the ability to completely disable all components in the chart, so that detailed manipulation can be performed later.

For example, to split into two separate releases, one with a separate controller, one with a separate webhook, and one with a separate CRD.

To perform such manipulation, we need to be able to disable each resource.

Example:

[root@control1 bash]# helm list
NAME                      	NAMESPACE      	REVISION    STATUS  	CHART                        	APP VERSION
cert-manager.controller         pfm-certmanager	1           deployed	cert-manager-v1.7.0-v2       	v1.7.0        
cert-manager.webhook          	pfm-certmanager	2           deployed	cert-manager-v1.7.0-v2       	v1.7.0     
cert-manager.crd          	pfm-certmanager	3           deployed	cert-manager-v1.7.0-v2       	v1.7.0     
cert-manager.monitoring         pfm-certmanager 1           deployed	cert-manager-v1.7.0-v2       	v1.7.0    

@cert-manager-prow
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 31, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added area/deploy Indicates a PR modifies deployment configuration needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2024
@cert-manager-prow
Copy link
Contributor

Hi @FR-Solution. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2024
Signed-off-by: Dmitrii Putilin <[email protected]>
Signed-off-by: Dmitrii Putilin <[email protected]>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels May 31, 2024
@FR-Solution
Copy link
Author

due to a large number of conflicts, the PR had to be reset; the discussion was held in this PR #5823

@FR-Solution
Copy link
Author

@munnerz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant