-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDAG] Upstream Multi-Device Selection + Tests #255
base: master
Are you sure you want to change the base?
Conversation
Check-perf-impact results: (7b849de16ff11660b98988ab0b032db7) ❓ No new benchmark data submitted. ❓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
}; | ||
std::shared_ptr<impl> m_pimpl; // Use PIMPL for reference semantics | ||
|
||
mock_device(impl i) : m_pimpl(std::make_shared<impl>(i)) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: the parameter 'i' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
mock_device(impl i) : m_pimpl(std::make_shared<impl>(i)) {} | |
mock_device(const impl& i) : m_pimpl(std::make_shared<impl>(i)) {} |
Pull Request Test Coverage Report for Build 9582564578Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarkable, this might be your best work yet! 😜 Jokes aside, the new backend selection logic looks good!
Now that it ended up being a separate commit after all, you could throw me a bone with a Co-authored-by
:-)
This upstreams the new device selection logic developed by @psalz for the old multi-GPU Celerity branch alongside modifications I made for the new IDAG backend logic.
While the old single-device selection logic remains in place until the IDAG execution PR, its tests are already replaced here to streamline the merge process.