Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the full calendar link clickable #15446

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rafi993
Copy link

@Rafi993 Rafi993 commented Jun 16, 2024

What does this PR do?

It adds padding to the link tag instead of the surrounding div in event listing so that the whole area is clickable

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code
  • I have added a Docs issue
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  1. Run the branch locally (or use the preview URL if it is available)
  2. Create multiple events
  3. Visit the public profile page
  4. Now the whole tile should be clickable not just the contents in the center

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Jun 16, 2024

@Rafi993 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Jun 16, 2024
Copy link
Contributor

github-actions bot commented Jun 16, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Make the full calendar link clickable". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@Rafi993 Rafi993 changed the title Make the full calendar link clickable fix: Make the full calendar link clickable Jun 16, 2024
@ashish1233
Copy link

LGTM!! @Rafi993
Thanks :)

Anurag12133 added a commit to Anurag12133/cal.com that referenced this pull request Jun 18, 2024
@keithwillcode keithwillcode added this to the v4.4 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The whole calendar tile is not clickable
3 participants