Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: floating button for scroll on booking page for mobile #15440

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shaik-Sirajuddin
Copy link
Contributor

What does this PR do?

This PR introduces an idea to add a floating button for scroll on mobile , to remove the need for scroll between calendar view and time slots in booker page on mobile devices

video6300788693351272820.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 15, 2024
@graphite-app graphite-app bot requested a review from a team June 15, 2024 16:36
Copy link

vercel bot commented Jun 15, 2024

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added booking-page area: booking page, public booking page, booker Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. labels Jun 15, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Jun 15, 2024
@dosubot dosubot bot added this to the v4.4 milestone Jun 15, 2024
Copy link

graphite-app bot commented Jun 15, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/15/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@PeerRich
Copy link
Member

I think a better approach to make the issue creator happy would be to make the top half sticky after scroll and keep it visible:
image

and then only scroll the times below

@Shaik-Sirajuddin
Copy link
Contributor Author

@PeerRich
This sounds a nice approach
Will implement it in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working community Created by Linear-GitHub Sync ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3694] Remove need to scroll when booking meeting on mobile
2 participants