feat: Autofill feature #15437
Open
feat: Autofill feature #15437
+114
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
consumer
Medium priority
Graphite Automations"Add community label" took an action on this PR • (06/14/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/14/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
bookings
Amit91848
commented
Jun 14, 2024
| ]); | ||
|
|
||
| // When initialValues is available(after doing async schema parsing) or session is available(so that we can prefill logged-in user email and name), we need to reset the form with the initialValues | ||
| // We also need the key to change if the bookingId changes, so that the form is reset and rerendered with the new initialValues | ||
| const key = `${Object.keys(initialValues).length}_${hasSession ? 1 : 0}_${initialValues?.bookingId ?? 0}`; | ||
| const key = `${prevResponse ? JSON.stringify(initialValues).length : Object.keys(initialValues).length}_${ |
There was a problem hiding this comment.
When previous responses were fetched, key was immediately updated and useEffect was executed before the initalValues could update. Not sure if this is the best way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Recording.2024-06-14.204324.mp4
Mandatory Tasks (DO NOT REMOVE)