fix: correctly assign status code on rate limit error #15435
Merged
+103
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/14/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
reviewed
Jun 14, 2024
Comment on lines
+19
to
+21
| } catch (error) { | ||
| res.status(429).json({ message: "Rate limit exceeded" }); | ||
| } |
There was a problem hiding this comment.
thinking about this, what's the outcome of catching the TRPC error sent by checkRateLimitAndThrowError and not throwing again afterward ? we might want to set status and json and then throw the error again
There was a problem hiding this comment.
Hmm will try that morgan
There was a problem hiding this comment.
Throwing an error in middle ware results in a 500 being thrown - Added tests this approach works as expected
keithwillcode
previously approved these changes
Jun 19, 2024
keithwillcode
approved these changes
Jun 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api middleware returns a 400 no matter what error is thrown. We need to specifically set the response code for middleware