Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: viewer/slots/util.ts refactor #15399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

santiosorio1357
Copy link

No description provided.

Copy link

vercel bot commented Jun 11, 2024

@santiosorio1357 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 11, 2024
@graphite-app graphite-app bot requested a review from a team June 11, 2024 02:49
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link

graphite-app bot commented Jun 11, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/11/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added this to the v4.4 milestone Jun 11, 2024
@PeerRich
Copy link
Member

hey can you explain more what this PR does and why?

@PeerRich PeerRich changed the title Util code refactoring chore: viewer/slots/util.ts refactor Jun 11, 2024
@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label Jun 11, 2024
@@ -809,12 +833,12 @@ export async function getAvailableSlots({ input, ctx }: GetScheduleOptions): Pro
{} as typeof slotsMappedToDate
);

loggerWithEventDetails.debug(`getSlots took ${getSlotsTime}ms and executed ${getSlotsCount} times`);
loggerWithEventDetails.debug(getSlots took ${getSlotsTime}ms and executed ${getSlotsCount} times);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a template string


loggerWithEventDetails.debug(
`checkForAvailability took ${checkForAvailabilityTime}ms and executed ${checkForAvailabilityCount} times`
checkForAvailability took ${checkForAvailabilityTime}ms and executed ${checkForAvailabilityCount} times
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync 💻 refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants