-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set conferencing apps as default #15376
base: main
Are you sure you want to change the base?
fix: set conferencing apps as default #15376
Conversation
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (06/08/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/08/24)1 reviewer was added to this PR based on Keith Williams's automation. |
It was installing normally and not setting it as default. I have added it to google meet only for now? Do want me to add it to all conferencing apps? |
Thank you, @Amit91848.
can you add it for all the oAuth-based conferencing apps |
Sure @SomayChauhan |
Added @SomayChauhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice, but can we sort video conferencing apps by popularity as well? We sort calendars already by popularity
ideally Google Meet (and Zoom etc.) is at the top
Will do @PeerRich |
Just checked it is already being sorted by popularity, local development doesn't have app count so isn't being reflected @PeerRich |
ah very nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ThankYou for the fix @Amit91848
added a small fix in 20fdb50
where the default event-types we create for the new user were not picking up the default app we just set.
PS: For OAuth apps, where the link is generated automatically we set the newly added conferencing app as the default location for all event types. For link-based apps, users can manually set the location.
What does this PR do?
Recording.2024-06-08.163855.mp4
Mandatory Tasks (DO NOT REMOVE)