Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set conferencing apps as default #15376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Recording.2024-06-08.163855.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

@graphite-app graphite-app bot requested a review from a team June 8, 2024 11:14
Copy link

vercel bot commented Jun 8, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jun 8, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jun 8, 2024
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Jun 8, 2024
Copy link

graphite-app bot commented Jun 8, 2024

Graphite Automations

"Add community label" took an action on this PR • (06/08/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (06/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Amit91848
Copy link
Contributor Author

when you sign up for a new account and choose Google Meet as the default meeting platform, for some reason it still keeps Cal Video as the default and you have to go to settings to change it manually

It was installing normally and not setting it as default. I have added it to google meet only for now? Do want me to add it to all conferencing apps?

@SomayChauhan
Copy link
Member

Thank you, @Amit91848.

It was installing normally and not setting it as default. I have added it to google meet only for now? Do want me to add it to all conferencing apps?

can you add it for all the oAuth-based conferencing apps

@Amit91848
Copy link
Contributor Author

Sure @SomayChauhan

@Amit91848
Copy link
Contributor Author

Added @SomayChauhan

PeerRich
PeerRich previously approved these changes Jun 9, 2024
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, but can we sort video conferencing apps by popularity as well? We sort calendars already by popularity

ideally Google Meet (and Zoom etc.) is at the top

@PeerRich PeerRich dismissed their stale review June 9, 2024 15:37

misclicked

@Amit91848
Copy link
Contributor Author

Will do @PeerRich

@Amit91848
Copy link
Contributor Author

looks nice, but can we sort video conferencing apps by popularity as well? We sort calendars already by popularity

ideally Google Meet (and Zoom etc.) is at the top

Just checked it is already being sorted by popularity, local development doesn't have app count so isn't being reflected @PeerRich

@PeerRich
Copy link
Member

PeerRich commented Jun 9, 2024

ah very nice

Copy link
Member

@SomayChauhan SomayChauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ThankYou for the fix @Amit91848
added a small fix in 20fdb50
where the default event-types we create for the new user were not picking up the default app we just set.

PS: For OAuth apps, where the link is generated automatically we set the newly added conferencing app as the default location for all event types. For link-based apps, users can manually set the location.

@dosubot dosubot bot modified the milestones: v4.3, v4.4 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3903] set conferencing apps as default
3 participants