Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only run E2E suite when ready-for-e2e label added #15364

Closed
wants to merge 30 commits into from

Conversation

keithwillcode
Copy link
Contributor

@keithwillcode keithwillcode commented Jun 6, 2024

What does this PR do?

Gives us optionality in terms of not always running the full E2E suite until manually triggered by adding the ‘ready-for-e2e’ label or when an approval happens, which automatically adds said label. We still protect the main branch because the required checks waits for the e2e test suite to complete and pass.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  • ensure that the PR update job run manually against this branch has succeeded.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 3:38pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 3:38pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 3:38pm

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode changed the title chore: Improve CI workflow chore: Only run E2E suite when ready-for-e2e label added Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests area: unit tests, e2e tests, playwright ci area: CI, DX, pipeline, github actions core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants