Boo.Lang.List conversion fix and revert and recompile of Old Naga engine #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byt3bl33d3r/Naga#3 fix for impersonateprocess.boo
list fix from byt3bl33d3r/Naga#3 for impersonateuser.boo
recompiled using an earlier commit prior to the Boo.Lang.List conversion changes.
|
I am currently using this fork. Works great, having numerous difficulties using master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, byt3bl33d3r.
Have completed a fair bit of testing on this I think apart from seat belt I have ironed out the declarations by applying the fix from kaftejiman to get rid of the Boo.Lang.List conversion error within the boo scripts.
This fix only works however when using the compiled version of naga prior to your last commit else you run into further Icompile errors when the source for the modules gets compiled and run. So this would require a roll back of the Naga repo as well. Feel free to clone and test this repo. It has updated and newly compiled naga and naga.dll versions in it compiled from an earlier commit of your Naga repo.
Not great at pull requests if this is less than useless feel free to bin it off and pull what you need from the fork.
cheers for ST!