WIP: Add STABLE_PACKAGE_NO_IMPORT_UNSTABLE lint rule #3010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not yet sure if we want to add this into mainline. Opening this for discussion.
This is re: #2986.
This adds a
STABLE_PACKAGE_NO_IMPORT_UNSTABLE
lint rule, with no category, that will produce a lint failure if an stable package imports a file with an unstable package. For example:a.proto
importsb.proto
, anda.proto
has packagea.v1
:b.proto
has packagefoo
, no failure - cannot determine package stability.b.proto
has packagefoo.v1
, no failure - stable imports stable.b.proto
has packagefoo.v1beta1
, failure - stable imports unstable.a.proto
has packagea
:a.proto
has packagea.v1beta1
:If we do decide to go ahead with this, this PR: