Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): Add ability to define the guideline option for all Terraform Resource Checks #6080

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

cawilson
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Including the same guideline option in the Terraform resource checks BaseResourceNegativeValueCheck and BaseResourceValueCheck, which passes through the option to the existing option in the BaseResourceCheck class.

Updated the associated tests to include setting the guideline option in addition to adding missing tests for the BaseResourceNegativeValueCheck Terraform resource check class.

This should be a non-breaking change which fills in a gap with the resource checks and setting the guideline option.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cawilson
Copy link
Author

@SteveVaknin any chance someone would be able to look into this minor change? 🙏🏻

Copy link
Contributor

@bo156 bo156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯
@cawilson can you rebase your code from main to retrigger the security-checks? I saw it failed.

@cawilson
Copy link
Author

Nice work 💯 @cawilson can you rebase your code from main to retrigger the security-checks? I saw it failed.

Just noticed your response (thank you!). I have merged main into my branch and so it should be good to go AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants