-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): Add ability to define the guideline
option for all Terraform Resource Checks
#6080
base: main
Are you sure you want to change the base?
feat(terraform): Add ability to define the guideline
option for all Terraform Resource Checks
#6080
Conversation
@SteveVaknin any chance someone would be able to look into this minor change? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💯
@cawilson can you rebase your code from main to retrigger the security-checks? I saw it failed.
Just noticed your response (thank you!). I have merged |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Including the same
guideline
option in the Terraform resource checksBaseResourceNegativeValueCheck
andBaseResourceValueCheck
, which passes through the option to the existing option in theBaseResourceCheck
class.Updated the associated tests to include setting the
guideline
option in addition to adding missing tests for theBaseResourceNegativeValueCheck
Terraform resource check class.This should be a non-breaking change which fills in a gap with the resource checks and setting the
guideline
option.Checklist: