-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include prisma_api_url and keys #132
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, thanks for the contribution 💪 small problem, the Prisma credentials can't be set like that, they need to be passed to the api-key
field.
@@ -155,3 +174,6 @@ runs: | |||
BITBUCKET_TOKEN: ${{ inputs.bitbucket_token }} | |||
BITBUCKET_USERNAME: ${{ inputs.bitbucket_username }} | |||
BITBUCKET_APP_PASSWORD: ${{ inputs.bitbucket_app_password }} | |||
PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} | |
PRISMA_API_URL: ${{ inputs. prisma_api_url }} |
@Juliandreslopez Hey, are you still planning on fixing the issue? |
@@ -155,3 +174,6 @@ runs: | |||
BITBUCKET_TOKEN: ${{ inputs.bitbucket_token }} | |||
BITBUCKET_USERNAME: ${{ inputs.bitbucket_username }} | |||
BITBUCKET_APP_PASSWORD: ${{ inputs.bitbucket_app_password }} | |||
PRISMA_API_URL: ${{ inputs.PRISMA_API_URL }} | |||
PRISMA_ACCESS_KEY: ${{ secrets.PRISMA_CLOUD_ACCESS_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would refrain from hard-coding a requirement on secrets
into the action and instead take required data as an input where a secret can be used if so desired. Additionally, the prisma api key and secret are ingestible already via the api-key
input in the format of <ACCESS_KEY>::<SECRET_KEY>
.
Please be sure to document usage in the README.md file. |
No description provided.