Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for multiple OS families #1476

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

TheTechromancer
Copy link
Collaborator

Addresses #1469.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92%. Comparing base (6f77f91) to head (efcdaff).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1476   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        327     327           
  Lines      21088   21112   +24     
=====================================
+ Hits       19368   19373    +5     
- Misses      1720    1739   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer
Copy link
Collaborator Author

@domwhewell-sage we've run into a potential issue with these tests. In order to test BBOT on multiple OS families, we need to run the tests inside a docker container. This will cause the dastardly tests to fail, since we can't do docker-in-docker.

🤔🤔

@domwhewell-sage
Copy link
Contributor

Do you think it would be possible to add this to the dastardly test

@pytest.mark.skipif(not subprocess.run(['docker', '--version'], capture_output=True).returncode == 0,
                    reason="Docker is not installed")

@TheTechromancer
Copy link
Collaborator Author

Hmm I guess we could exclude it from the os family tests, but modules like dastardly with big dependencies are the reason we need those tests to begin with.

I'll see about excluding it for now, and maybe we can figure out a better solution further down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants