option to opt-out of children invalidation #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the invalid method option invalidates children by default, as a consequence from allowing handles (if a parent is invalid, the handle and in-between elements should not be dragged) but when nesting one might need to invalidate only up to one parent (keep validating from the handle to the item but not further in the draggable hierarchy) TODO : use a complex return value to differentiate handle and draggable element when nesting (event+propagation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the invalid method option invalidates children by default, as a consequence from allowing handles (if a parent is invalid, the handle and in-between elements should not be dragged)
but when nesting one might need to invalidate only up to one parent (keep validating from the handle to the item but not further in the draggable hierarchy)
TODO : use a complex return value to differentiate handle and draggable element when nesting (event+propagation)
This was a change that I prepared years ago, to do some nesting as seen in #31
My changes are working on that example : http://www.sherbrow.fr/labs/flow1.html