Fix Issue with _stepCount Not Resetting, Causing Infinite Separator Exceptions #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where _stepCount was not being reset, causing ThrowInfiniteSeparators() to be triggered as _stepCount accumulated over time, even though the actual step count did not exceed 10,000. (beto-rodriguez#1076 (comment)) Now, _stepCount is reset to 0 before each relevant logic check. This resolved the exception that occurred about 10 minutes after the chart was displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Problem
In the WinUI application, there was an issue where the
_stepCountvariable was not being reset, despite the UI not visibly exceeding 10,000 steps. Over time,_stepCountaccumulated due to continuous use, which eventually triggeredThrowInfiniteSeparators()method calls.Solution
To address this issue, I implemented a change where
_stepCountis reset to 0 before each logic check that involves this variable.Verification
Post-implementation, the change was tested by monitoring the application for extended periods. The fix proved effective, as the application no longer threw exceptions after approximately 10 minutes of uptime while showing graphs, a common occurrence prior to this update.
Related Issue
This fix also appears to resolve a similar issue reported in Issue #1076, further indicating the effectiveness of this solution.