Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ASCII animation was not working properly in the image builder logs #4810

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

yetone
Copy link
Member

@yetone yetone commented Jun 16, 2024

What does this PR address?

馃憟 BentoML CLI 馃啔 kubectl 馃憠

ascii-animation-4k.mp4

Before submitting:

@yetone yetone requested a review from a team as a code owner June 16, 2024 08:50
@yetone yetone requested review from ssheng and removed request for a team June 16, 2024 08:50
@yetone yetone force-pushed the fix/ascii-animation branch 2 times, most recently from 25fb983 to 38d013c Compare June 16, 2024 14:28
@parano parano requested a review from frostming June 16, 2024 23:26
src/bentoml/_internal/cloud/client.py Outdated Show resolved Hide resolved
src/bentoml/_internal/cloud/client.py Outdated Show resolved Hide resolved
src/bentoml/_internal/cloud/deployment.py Outdated Show resolved Hide resolved
@yetone yetone requested a review from frostming June 17, 2024 07:22
@yetone yetone force-pushed the fix/ascii-animation branch 4 times, most recently from 0313cc9 to 5c14131 Compare June 17, 2024 08:38
Copy link
Contributor

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interfaces of Spinner don't look good, will refactor later.

Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few tiny things, with the types we can upgrade to newer syntax as a whole in a later PR.

@frostming frostming merged commit 4d85863 into bentoml:main Jun 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants