Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment-client): add build process and extend url #4790

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

Haivilo
Copy link
Contributor

@Haivilo Haivilo commented Jun 11, 2024

What does this PR address?

  1. Long url can be shown:
    Screenshot 2024-06-11 at 2 30 13 AM

  2. bento build progress is added:
    Screenshot 2024-06-11 at 2 29 57 AM

Fixes #(issue)

Before submitting:

@Haivilo Haivilo requested a review from a team as a code owner June 11, 2024 09:52
@Haivilo Haivilo requested review from aarnphm, parano, FogDong and frostming and removed request for a team June 11, 2024 09:52
@frostming
Copy link
Contributor

frostming commented Jun 11, 2024

IMO the Spinner class is too complicated for such job, do you mind I propose something simpler?

I mean, all we need is a spinner status, and a panel of text.

But Spinner uses three progress bars for this, and rich's progress bar itself supports multiple tasks. It doesn't make sense to me. I think the main cause of the problem is that we used an improper API(progress bar) to display a plain text.

@aarnphm aarnphm changed the title fix(deployement-client): add build process and extend url fix(deployment-client): add build process and extend url Jun 12, 2024
@frostming
Copy link
Contributor

Since #4796 is also ongoing let's keep the current implementation to avoid more conflicts.

We can refactor it after both are merged.

@frostming
Copy link
Contributor

Hi, @Haivilo I've done some refactor around the Spinner class, you may need to update your PR. Thanks!

@Haivilo
Copy link
Contributor Author

Haivilo commented Jun 21, 2024

Thanks @frostming! I think the only change needed here now is to distinguish between using SDK or CLI. I have updated the PR; could you please take another look?

@frostming frostming merged commit 7132bd3 into bentoml:main Jun 21, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants