Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get_service api for selected frameworks #4782

Merged
merged 18 commits into from
Jun 25, 2024

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

What does this PR address?

Fixes #(issue)

Before submitting:

frostming and others added 16 commits June 3, 2024 10:34
* fix: add secrets management command

* chore: add file type secret

* chore: update command help text

* chore: add deployment option secret

* fix: add delete command

* chore: add secret Apply command

* chore: update mountAs

* chore: update import

* chore: update secret api route
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
@frostming frostming marked this pull request as ready for review June 14, 2024 02:40
@frostming frostming requested a review from a team as a code owner June 14, 2024 02:40
@frostming frostming requested review from xianml and removed request for a team June 14, 2024 02:40
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me for all of the framework implementation.

One question for the save, load API: I guess it is a good time to remove it now?

@frostming
Copy link
Contributor Author

One question for the save, load API: I guess it is a good time to remove it now?

Since I removed all the bentoml.* proxy modules, these APIs removed, too.

@frostming frostming force-pushed the dev/1.3 branch 2 times, most recently from 89ee487 to acb3d1a Compare June 20, 2024 08:28
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merge when you can

@frostming frostming merged commit ff55628 into bentoml:dev/1.3 Jun 25, 2024
39 of 40 checks passed
@frostming frostming deleted the feat/framework branch June 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants