-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[huggingface_pytorch] Inference - update for HuggingFace Transformers to 4.41.2 - PyTorch 2.2 #3872
base: master
Are you sure you want to change the base?
Conversation
This PR has been marked stale as a result of being open for 30 days without activity or updates. Please remove the stale label or comment in order to keep this open, otherwise the PR will be closed in 5 days. |
Any updates on this? I would like to use the new transformers version ASAP. |
Hi @asai-carbon, I pinged sagemaker team for review, let's see how it goes. Sorry about the delay. |
@JingyaHuang I tried building the inference image on my M1 Mac with Transformers 4.40.1. I had some questions about the process outlined in the repo instructions.
The command I ran was the following (after copying the files in this PR related to the new HuggingFace Pytorch inference image DockerFile):
Examples:
Do you know what would cause this and how to resolve?
|
GitHub Issue #3871 :
Description
This PR updates Hugginface's PyTorch DLC for inference. Here are the corresponding updated dependencies versions:
transformers: 4.41.2
torch: 2.2.0
diffusers: 0.28.2
accelerate: 0.31.0
peft: 0.11.1
Tests run
NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"
NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:
Expand
sagemaker_remote_tests = true
sagemaker_efa_tests = true
sagemaker_rc_tests = true
Additionally, please run the sagemaker local tests in at least one revision:
sagemaker_local_tests = true
Formatting
black -l 100
on my code (formatting tool: https://black.readthedocs.io/en/stable/getting_started.html)DLC image/dockerfile
Builds to Execute
Expand
Click the checkbox to enable a build to execute upon merge.
Note: By default, pipelines are set to "latest". Replace with major.minor framework version if you do not want "latest".
Additional context
PR Checklist
Expand
NEURON/GRAVITON Testing Checklist
dlc_developer_config.toml
in my PR branch by settingneuron_mode = true
orgraviton_mode = true
Benchmark Testing Checklist
dlc_developer_config.toml
in my PR branch by settingec2_benchmark_tests = true
orsagemaker_benchmark_tests = true
Pytest Marker Checklist
Expand
@pytest.mark.model("<model-type>")
to the new tests which I have added, to specify the Deep Learning model that is used in the test (use"N/A"
if the test doesn't use a model)@pytest.mark.integration("<feature-being-tested>")
to the new tests which I have added, to specify the feature that will be tested@pytest.mark.multinode(<integer-num-nodes>)
to the new tests which I have added, to specify the number of nodes used on a multi-node test@pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">)
to the new tests which I have added, if a test is specifically applicable to only one processor typeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.