-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyboard command #369
base: v1
Are you sure you want to change the base?
add keyboard command #369
Conversation
チャット欄フォーカス |
refをChatInput内で定義しているため、liftupするか、ref合成の必要ありそう? |
綺麗ではないけどText Areaに個別にEffect追加 |
Lint修正 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRありがとうございます!
コメントをご確認くださいmm
<> | ||
<div className="flex justify-between px-4 pb-2"> | ||
<div /> | ||
<PiQuestionFill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
アプリのデザイン思想として、「必ずクリックする必要のあるもの」「注意してクリックする必要があるもの」などを除き、outlinedなボタンにしています。
ヘルプはそれらに該当しないので、fill
ではないアイコンをご利用くださいmm
送信ボタンがoutlinedなので、直したい気持ちになってきました。。
余裕があったら、 修正をお願いしますmm
(ボーダー無し、bg-aws-sea-blue hover:bg-aws-sea-blue-hover text-white
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
送信ボタンがoutlinedなので、直したい気持ちになってきました。。
余裕があったら、 修正をお願いしますmm
こちら承知です!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!助かります!
アイコンの存在感を出したいので、Fiil
なアイコンでお願いしますmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すいません、認識誤ってましたmm
修正しました!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wadabee |
sample code var ua = window.navigator.userAgent.toLowerCase();
if(ua.indexOf("windows nt") !== -1) {
console.log("「Microsoft Windows」をお使いですね!");
} else if(ua.indexOf("android") !== -1) {
console.log("「Android」をお使いですね!");
} else if(ua.indexOf("iphone") !== -1 || ua.indexOf("ipad") !== -1) {
console.log("「iOS」をお使いですね!");
} else if(ua.indexOf("mac os x") !== -1) {
console.log("「macOS」をお使いですね!");
} else {
console.log("何をお使いなのですか?");
} |
Premise : macOS
|
window.navigator?.userAgentData
?.getHighEntropyValues(['platformVersion'])
?.then((ua) => {
if (navigator.userAgentData.platform === 'Windows') {
const majorPlatformVersion = parseInt(
ua.platformVersion.split('.')[0]
);
if (majorPlatformVersion >= 13) {
console.log('Windows 11 or later');
} else if (majorPlatformVersion > 0) {
console.log('Windows 10');
} else {
console.log('Before Windows 10');
}
} else {
console.log('Not running on Windows');
}
}); See : https://learn.microsoft.com/ja-jp/microsoft-edge/web-platform/how-to-detect-win11 |
import Bowser from 'bowser';
...
const browser = Bowser.getParser(window.navigator.userAgent);
const os = browser.getOSName(); build-in |
ありがとうございます! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応ありがとうございます!
コメントのご確認お願いしますmm
const browser = Bowser.getParser(window.navigator.userAgent); | ||
const os = browser.getOSName(); | ||
const isWindows = os === 'Windows'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここ以外でも利用しているので、Hooks等を使って共通化していただけないでしょうか?
@@ -511,6 +511,15 @@ How would you categorize this email?`, | |||
message: 'Please input both Title and Conversation Example.', | |||
}, | |||
}, | |||
heler: { | |||
shortcuts: { | |||
title: 'shortcut keys', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見出しは単語を大文字始まりにしているので、修正をお願いします!
Shortcut Keys
のようなイメージです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
承知しました!
<> | ||
<div className="flex justify-between px-4 pb-2"> | ||
<div /> | ||
<PiQuestionFill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue #, if available:
#370
#368
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.