Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid_view? helper method to support grid view detection #2831

Closed
wants to merge 6 commits into from

Conversation

gabrielgiroe1
Copy link
Collaborator

Description

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@gabrielgiroe1 gabrielgiroe1 self-assigned this Jun 3, 2024
Copy link

codeclimate bot commented Jun 3, 2024

Code Climate has analyzed commit 96d55a9 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right approach.
Please search @view_type and available_view_types and see how they work together.

If we add this change that you're making, we're back at two places where we do the params[:view_type] == "grid" check.
Let's bring it all in one place/helper/something.

Check these places too:

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants