feature: click row to view record #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 3a090c2 and detected 0 issues on this pull request. View more on Code Climate. |
adrianthedev
commented
Jun 17, 2024
| export default class extends Controller { | ||
| visitRecord(event) { | ||
| if (event.type === 'click') { | ||
| const isLinkOrButton = event.target.closest('a, button, svg') |
There was a problem hiding this comment.
We need to see how the support is for svgs that need to be clicked (status field x icon).
…to feature/make-row-clickable
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to enable clickable rows on Avo's tables.
TO-DO
Checklist:
Screenshots & recording
CleanShot.2024-05-31.at.18.04.19.mp4
Manual review steps
click_row_to_view_recordin the initializerManual reviewer: please leave a comment with output from the test if that's the case.