Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a new, experimental variant of LookupResources as LookupResources2 #1905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement a new, experimental variant of LookupResources as LookupResources2 #1905

wants to merge 1 commit into from

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented May 20, 2024 •
edited
Loading

This implementation should be much faster for intersections, exclusions and caveats due to early tree shearing and check hints

This change has three major components:

  1. Change to caveats expression handling to early terminate when relevant
  2. Ability to specify hints to checks to avoid recompuation
  3. Implementation of LR2

@github-actions github-actions bot added area/CLI Affects the command line area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) area/dispatch Affects dispatching of requests labels May 20, 2024
@josephschorr josephschorr marked this pull request as ready for review May 21, 2024 15:26
@josephschorr josephschorr requested a review from a team as a code owner May 21, 2024 15:26
@josephschorr josephschorr mentioned this pull request May 23, 2024
Open
@josephschorr
Implement a new, experimental variant of LookupResources as LookupRes…
f7be8ea 
…ources2

This implementation should be much faster for intersections, exclusions and caveats due to early tree shearing and check hints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josephschorr josephschorr

Labels
area/api v1 Affects the v1 API area/CLI Affects the command line area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@josephschorr