fix(ui): parameter descriptions shouldn't disappear on input #13244
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the `map` statement missed `description` (and other parts of a `Parameter`) as it only listed a few fields and not all of them
- use spread args to (shallow-)copy over the whole object instead, and then just overwrite the `value` as nothing else changes
- spread makes this a lot more future-proof and less buggy, since we're not re-typing all of the unchanged fields
- we might be able to further optimize this by re-using the same object when its value is unchanged (which will be the majority of cases since the whole array is modified at once)
Signed-off-by: Anton Gilgur <[email protected]>
- revert to old style with `newParameters` variable - it feels more readable than what `prettier` wants 😅 - my editor was apparently lagging quite heavily in showing this in my previous commit (I only saw it when I re-opened the file), seemed like a stale lint cache or something Signed-off-by: Anton Gilgur <[email protected]>
tczhao
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13242
Motivation
Per the issue, parameter tooltips/descriptions would disappear for all parameters as soon as you entered any text into any one of the parameter inputs. This buggy behavior would ofc make tooltips substantially less useful.
Modifications
mapstatement misseddescription(and other parts of aParameter) as it only listed a few fields and not all of themvalueas nothing else changesVerification
Confirmed it was working locally after typing some inputs. Screenshot:
Backport Notes
This is not directly backportable to 3.4 as the code has changed quite a bit (e.g. this shared component didn't exist and it used class components before). But the diff can be copy+pasted to the equivalent section in 3.4 if someone wants it.
Future Work
We might be able to further optimize this by re-using the same object when its value is unchanged (which will be the majority of cases since the whole array is modified at once). I just fixed the bug at this time