Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(retest): filter more comments to use GHA less #13208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agilgur5
Copy link
Member

Follow-up to #13000

Motivation

  • they get triggerred quite often (for every comment), and though they only run for 2s, it would be good to filter out more of them and use less CI time

Modifications

  • only run on created events, skip all edited events

    • the vast majority of edited events will be for unrelated comments
    • you can delete and comment again to trigger a retest instead if you had a typo
  • only run on PR comments, following GH docs

    • it would fail otherwise, but this prevents that scenario entirely

Verification

- they get triggerred [quite often](https://github.com/argoproj/argo-workflows/actions/workflows/retest.yaml) (for every comment), and though they only run for 2s, it would be good to filter out more of them and use less CI time

- only run on `created` events, skip all `edited` events
  - the vast majority of `edited` events will be for unrelated comments
  - you can delete and comment again to trigger a retest instead if you had a typo
- only run on PR comments
  - it would fail otherwise, but this prevents that scenario entirely

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues prioritized-review For members of the Sustainability Effort labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues prioritized-review For members of the Sustainability Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant