feat: Extend character limit for API, query, and datasource names #34358
Conversation
WalkthroughThe recent updates focus on enhancing input components by introducing maximum length constraints, full width usage, and improved validation logic. The changes span across various files, optimizing name validation, incorporating special character removal, and refining dependencies in functions and hooks within the codebase. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- app/client/src/components/editorComponents/ActionNameEditor.tsx (3 hunks)
- app/client/src/components/utils/NameEditorComponent.tsx (3 hunks)
- app/client/src/pages/Editor/DataSourceEditor/FormTitle.tsx (2 hunks)
- app/client/src/utils/helpers.tsx (2 hunks)
Additional context used
Biome
app/client/src/pages/Editor/DataSourceEditor/FormTitle.tsx
[error] 88-90: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
app/client/src/utils/helpers.tsx
[error] 82-133: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)
Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.
[error] 328-348: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 344-347: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 353-353: Unexpected control character(s) in regular expression: \x00, \x1f (lint/suspicious/noControlCharactersInRegex)
Control characters are unusual and potentially incorrect inputs, so they are disallowed.
[error] 588-588: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
[error] 703-710: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 704-710: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 705-710: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 706-710: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 707-710: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 763-763: This default parameter should follow the last required parameter or should be a required parameter. (lint/style/useDefaultParameterLast)
The last required parameter is here:
A default parameter that precedes a required parameter cannot be omitted at call site.
Unsafe fix: Turn the parameter into a required parameter.
[error] 969-988: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 975-988: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 982-988: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
[error] 1055-1065: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 61-61: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)
Unsafe fix: Use the '**' operator instead of 'Math.pow'.
Additional comments not posted (5)
app/client/src/components/editorComponents/ActionNameEditor.tsx (1)
118-119: Increase themaxLengthto 256 and setuseFullWidthto ensure the input field utilizes the available space.app/client/src/components/utils/NameEditorComponent.tsx (2)
114-116: Simplified theisInvalidNameForEntityfunction to improve readability and performance by merging conditions and reducing complexity.
127-127: Updated theuseCallbackdependencies to includesuffixErrorMessage, ensuring that the hook recalculates when this message changes.app/client/src/pages/Editor/DataSourceEditor/FormTitle.tsx (1)
13-13: Extended themaxLengthto 256 and addedvalueTransformanduseFullWidthproperties to enhance input handling and UI consistency.Also applies to: 146-146, 152-153
app/client/src/utils/helpers.tsx (1)
175-177: Simplified theremoveSpecialCharsfunction to enhance efficiency by using a regular expression to replace special characters with underscores.
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
Description of the PR
I have raised this PR inorder to
To extends the character limit for API, query, and datasource names, allowing for more descriptive and clearer identifiers in the system.馃摳 Screenshoots
here we gave query name more than 30 characters
When you hover over a query that isn't visible, a tooltip appears displaying the query's name as below.
Summary by CodeRabbit
New Features
TextFieldcomponent with amaxLengthof 256 anduseFullWidthattribute inActionNameEditor.FormTitlecomponent usingremoveSpecialChars.Improvements
NameEditorComponentfor improved performance.maxLengthproperty to 256 characters inFormTitlecomponent.