Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move to Postgres #29492

Draft
wants to merge 479 commits into
base: release
Choose a base branch
from
Draft

feat: Move to Postgres #29492

wants to merge 479 commits into from
+7,075 −10,499

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Dec 9, 2023 •
edited by github-actions bot
Loading

PR for moving Appsmith from MongoDB backend to Postgres.

/test all

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9691006862
Commit: 92a9ec0
Cypress dashboard.
Tags: ``
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts
  2. cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts
  3. cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts
List of identified flaky tests.

@github-actions github-actions bot added the Enhancement New feature or request label Dec 9, 2023
@github-actions GitHub Actions
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Dec 23, 2023
@github-actions GitHub Actions
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Dec 31, 2023
@sharat87 sharat87 reopened this Jan 18, 2024
@github-actions GitHub Actions
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Feb 17, 2024
@sharat87 sharat87 reopened this Apr 2, 2024
sharat87 and others added 17 commits April 2, 2024 16:23
@sharat87
remove MongoDB... I think
bc31fee
@sharat87
chore: merge release branch
58f8ac5
@sharat87
fix dependencies for MongoDB plugin
30cf816
@sharat87
removed more bson API usages
23764de
@sharat87
more fixes to remove MongoDB dependency
007e539
@sharat87
Some more fixes for removal of MongoDB dependency
7b0c9f2
@sharat87
Build success!!
1b0a4e7
@sharat87
chore: merge release branch
64cdad9
@sharat87
fix build errors in tests
22a6c7e
@sharat87
chore: merge release branch
02c55b1
@sharat87
chore: merge release branch
360978f
@sharat87
fmt
a50a502
@sharat87
chore: merge release branch
2cc75e2
@sharat87
chore: Remove debug changes
ca543cc
@sharat87
fix: Fix transactional annotation usage
d3263b7
@sharat87
chore: merge release branch
845b061
@abhvsn
fix: Workspace service tests (#32546)
695ce59 
## Description
PR to fix the repo level method to fix workspace service test. In this
corrected query:

- $[*].pluginId: This selects the "pluginId" property from each element
of the JSON array within the "plugins" column.

- ? (@ == $p): This condition checks if any element in the selected
array has a "pluginId" property equal to the value provided by the
parameter $p.
@abhvsn
feat: Add in clause for enums and fix zipWith for flux (#34557)
57309b7 
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@github-actions GitHub Actions
Copy link

Failed server tests

  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withActions_returnsValidLayout
  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withEmptyActions_returnsValidLayout
  • com.appsmith.server.repositories.ce.CustomNewPageRepositoryTest#findPageWithoutBranchName
  • com.appsmith.server.services.ConsolidatedAPIServiceImplTest#testErrorResponseWhenAnonymousUserAccessPrivateApp
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenInstanceEmailVerificationIsNotEnabled_ThrowsException
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenUserEmailAlreadyVerified_ThrowsException
  • com.appsmith.server.services.UserServiceTest#updateInvalidUserWithAnything
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendForgotPasswordEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendInviteUserToWorkspaceEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#testSendInstanceAdminInviteEmail
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_disableMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_emptyMapForPendingMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_enableMigration_statesUpdate
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_emptyMigrationMap_revertSameTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_withPendingMigration_getUpdatedTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#ensureMapsKey
  • com.appsmith.server.services.ce.TenantServiceCETest#setMapsKeyWithoutAuthentication

@github-actions GitHub Actions
Copy link

Failed server tests

  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withActions_returnsValidLayout
  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withEmptyActions_returnsValidLayout
  • com.appsmith.server.repositories.ce.CustomNewPageRepositoryTest#findPageWithoutBranchName
  • com.appsmith.server.services.ActionCollectionServiceTest#testActionCollectionInViewMode
  • com.appsmith.server.services.ConsolidatedAPIServiceImplTest#testErrorResponseWhenAnonymousUserAccessPrivateApp
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenInstanceEmailVerificationIsNotEnabled_ThrowsException
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenUserEmailAlreadyVerified_ThrowsException
  • com.appsmith.server.services.UserServiceTest#updateInvalidUserWithAnything
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendForgotPasswordEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendInviteUserToWorkspaceEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#testSendInstanceAdminInviteEmail
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_disableMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_emptyMapForPendingMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_enableMigration_statesUpdate
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_emptyMigrationMap_revertSameTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_withPendingMigration_getUpdatedTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#ensureMapsKey
  • com.appsmith.server.services.ce.TenantServiceCETest#setMapsKeyWithoutAuthentication

@github-actions GitHub Actions
Copy link

Failed server tests

  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withActions_returnsValidLayout
  • com.appsmith.server.refactors.ce.RefactoringServiceCEImplTest#testRefactorCollectionName_withEmptyActions_returnsValidLayout
  • com.appsmith.server.repositories.ce.CustomNewPageRepositoryTest#findPageWithoutBranchName
  • com.appsmith.server.services.ActionCollectionServiceTest#testActionCollectionInViewMode
  • com.appsmith.server.services.ConsolidatedAPIServiceImplTest#testErrorResponseWhenAnonymousUserAccessPrivateApp
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenInstanceEmailVerificationIsNotEnabled_ThrowsException
  • com.appsmith.server.services.UserServiceTest#emailVerificationTokenGenerate_WhenUserEmailAlreadyVerified_ThrowsException
  • com.appsmith.server.services.UserServiceTest#updateInvalidUserWithAnything
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendForgotPasswordEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#sendInviteUserToWorkspaceEmail
  • com.appsmith.server.services.ce.EmailServiceCEImplTest#testSendInstanceAdminInviteEmail
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_disableMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_emptyMapForPendingMigration_statesUpdate
  • com.appsmith.server.services.ce.FeatureFlagServiceCETest#getAllRemoteFeaturesForTenantAndUpdateFeatureFlagsWithPendingMigrations_enableMigration_statesUpdate
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_emptyMigrationMap_revertSameTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#checkAndExecuteMigrationsForTenantFeatureFlags_withPendingMigration_getUpdatedTenant
  • com.appsmith.server.services.ce.TenantServiceCETest#ensureMapsKey
  • com.appsmith.server.services.ce.TenantServiceCETest#setMapsKeyWithoutAuthentication

@github-actions GitHub Actions
Copy link

Failed server tests

  • com.external.plugins.RestApiPluginTest#testDenyInstanceMetadataAwsViaCname
  • com.external.plugins.RestApiPluginTest#testDenyInstanceMetadataAwsWithRedirect

@sharat87
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9715794653.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29492.
recreate: .

@sharat87
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9715844474.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29492.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29492.dp.appsmith.com

1 similar comment
@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29492.dp.appsmith.com

@github-actions GitHub Actions
Copy link

Failed server tests

  • com.appsmith.server.services.ActionCollectionServiceTest#testActionCollectionInViewMode

@sharat87
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9716595951.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29492.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29492.dp.appsmith.com

@sharat87
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9716973502.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29492.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29492.dp.appsmith.com

@sharat87
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9717435313.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 29492.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-29492.dp.appsmith.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale ApekshaBhosale will be requested when the pull request is marked ready for review ApekshaBhosale is a code owner

@pratapaprasanna pratapaprasanna Awaiting requested review from pratapaprasanna pratapaprasanna will be requested when the pull request is marked ready for review pratapaprasanna is a code owner

@vivonk vivonk Awaiting requested review from vivonk vivonk will be requested when the pull request is marked ready for review vivonk is a code owner

@abhvsn abhvsn Awaiting requested review from abhvsn abhvsn will be requested when the pull request is marked ready for review abhvsn is a code owner

@nidhi-nair nidhi-nair Awaiting requested review from nidhi-nair nidhi-nair will be requested when the pull request is marked ready for review nidhi-nair is a code owner

@sondermanish sondermanish Awaiting requested review from sondermanish sondermanish will be requested when the pull request is marked ready for review sondermanish is a code owner

@NilanshBansal NilanshBansal Awaiting requested review from NilanshBansal NilanshBansal will be requested when the pull request is marked ready for review NilanshBansal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement New feature or request ok-to-test Required label for CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sharat87 @abhvsn @vivonk