Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallbacks to an empty object during "getFromString" #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artem-zakharchenko
Copy link
Contributor

  • Fixes an issue in the Core app when headers.values.expected is not defined sometimes.

@honzajavorek
Copy link
Contributor

We were able to identify the root cause and I think we should compensate for it in the apiary.io core app. Although we could say that this PR supports the robustness principle, I think in this case gavel2html shouldn't be benevolent and should throw on unexpected input structure. This actually helps to catch mistakes early.

@artem-zakharchenko
Copy link
Contributor Author

I would love not to introduce this handling, as it's too much for gavel2html. Would need to investigate the core problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants